Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Move type check when deserializing into the graph navigator" #1103

Merged
merged 4 commits into from
Jun 28, 2019

Conversation

goetas
Copy link
Collaborator

@goetas goetas commented Jun 28, 2019

Reverts #1080

Closes #1102

This bugfix resolves a regression introduced in #1080 and reported in #1102

The thing is that the JSON visitor complains about a missing type right before visiting that property.
Te XML visitor complains immediately, even if the property is not present in the data to visit.

To align the behavior of the two visitors I have relaxed the XML visitor. This unfortunately now had duplicated the check for metadata... that is kinda ugly (and should be fixed).

@goetas goetas added the bug label Jun 28, 2019
@goetas goetas force-pushed the revert-1080-metadata-check branch from 36ef2a7 to 6802d67 Compare June 28, 2019 08:49
@goetas goetas merged commit 0d6a49b into master Jun 28, 2019
@goetas goetas deleted the revert-1080-metadata-check branch September 20, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not deserialize object if all properties have not type
1 participant